Skip to content

catch undefined for leftArgs[0] and rightArgs[0]#118

Closed
karlhaas wants to merge 1 commit intoweb-animations:devfrom
karlhaas:patch-1
Closed

catch undefined for leftArgs[0] and rightArgs[0]#118
karlhaas wants to merge 1 commit intoweb-animations:devfrom
karlhaas:patch-1

Conversation

@karlhaas
Copy link
Copy Markdown

@karlhaas karlhaas commented Apr 4, 2017

Fix for #115

@karlhaas karlhaas mentioned this pull request Apr 4, 2017
Closed
@karlhaas karlhaas changed the title catch undefined for leftArgs[0] and ightArgs[0]) catch undefined for leftArgs[0] and rightArgs[0] Apr 4, 2017
@alancutter
Copy link
Copy Markdown
Contributor

alancutter commented Apr 7, 2017

Thanks for writing up this fix for us!
Before we can accept your submission we require you sign the Contributor License Agreement. Sorry for the hassle.

I think it might be better to change

web-animations-js/src/matrix-decomposition.js

Line 124 in 5f3d17f

return false;
to return null instead for consistency with itself.
It should also be relatively simple to add a test for this bug as well in https://github.com/web-animations/web-animations-js/blob/5f3d17fbb60dd82a3775f0c7fd7667f787096deb/test/js/transform-handler.js by giving it something like matrix(0, 0, 0, 0, 0, 0) as one of the keyframe inputs.

@karlhaas
Copy link
Copy Markdown
Author

karlhaas commented Apr 7, 2017

It says "It looks like you've already signed this CLA". I'm not really familiar with the source and just fixed the problem I found by debugging the source (it would have been easier if there would have been a non minified version of the bundle ;) )
Maybe someone who knows the code base better should provide further improvements.

@alancutter alancutter mentioned this pull request Apr 12, 2017
Merged
@alancutter
Copy link
Copy Markdown
Contributor

alancutter commented Apr 13, 2017

Maybe someone who knows the code base better should provide further improvements.

Landed a fix in #121, thanks again for doing the initial investigation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karlhaas @alancutter